Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new MobileTokenData.Builder system to provide a structured approach for composing additional data attached to operations during authorization or rejection. The builder supports both generic key-value pairs and structured records with time synchronization capabilities.
Key changes:
- Added MobileTokenData.Builder for type-safe composition of operation metadata
- Introduced PreApprovalScreensRecorder to track user flow through pre-approval screens with timestamped actions
- Created MobileTokenDataRecord interface for extensible structured data records
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| PreApprovalScreenRecorder.kt | New recorder class for tracking pre-approval screen visits with timestamps and user actions |
| MobileTokenDataRecord.kt | Interface defining the contract for structured data records in the builder system |
| MobileTokenDataBuilder.kt | Main builder class with thread-safe operations and helper management for composing mobile token data |
| IntegrationTests.kt | Added comprehensive tests for the new builder system and pre-approval recorder functionality |
| Using-Operations-Service.md | Updated documentation with examples and usage patterns for the new builder system |
| Migration-2.4.md | Added migration notes describing the new MobileTokenData.Builder functionality |
...om/wultra/android/mtokensdk/api/operation/model/mobiletokendata/PreApprovalScreenRecorder.kt
Outdated
Show resolved
Hide resolved
marek-ch
reviewed
Oct 17, 2025
...a/com/wultra/android/mtokensdk/api/operation/model/mobiletokendata/MobileTokenDataBuilder.kt
Show resolved
Hide resolved
marek-ch
reviewed
Oct 17, 2025
...a/com/wultra/android/mtokensdk/api/operation/model/mobiletokendata/MobileTokenDataBuilder.kt
Outdated
Show resolved
Hide resolved
marek-ch
previously approved these changes
Oct 17, 2025
Contributor
marek-ch
left a comment
marek-ch
left a comment
There was a problem hiding this comment.
Ok for me, but I'd discuss the opened questions.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
docs/Using-Operations-Service.md:1
# Using Operations Service
docs/Using-Operations-Service.md:1
# Using Operations Service
docs/Using-Operations-Service.md:1
# Using Operations Service
...a/com/wultra/android/mtokensdk/api/operation/model/mobiletokendata/MobileTokenDataBuilder.kt
Outdated
Show resolved
Hide resolved
kober32
requested changes
Oct 29, 2025
Member
kober32
left a comment
kober32
left a comment
There was a problem hiding this comment.
Looks OK, just fix the docs please and consider the small changes I suggested...
...a/com/wultra/android/mtokensdk/api/operation/model/mobiletokendata/MobileTokenDataBuilder.kt
Outdated
Show resolved
Hide resolved
...om/wultra/android/mtokensdk/api/operation/model/mobiletokendata/PreApprovalScreenRecorder.kt
Outdated
Show resolved
Hide resolved
kober32
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#218