Add actionSettings to PreApprovalElementButton#224
Merged
Hopsaheysa merged 2 commits intodevelopfrom Nov 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an optional actionSettings property to the PreApprovalElementButton class in the pre-approval UI template, allowing buttons to specify additional behavior or secondary actions (e.g., "REJECT").
- Added
actionSettingsfield toPreApprovalElementButtonmodel class - Updated type adapter to parse the new field from JSON
- Added comprehensive test coverage for the new property
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| library/src/main/java/com/wultra/android/mtokensdk/api/operation/model/preapproval/PreApprovalElement.kt | Added actionSettings property to PreApprovalElementButton class and updated KDoc |
| library/src/main/java/com/wultra/android/mtokensdk/api/operation/PreApprovalElementTypeAdapter.kt | Updated type adapter to parse actionSettings from JSON and pass it to constructor |
| library/src/androidTest/java/OperationUIDataTests.kt | Added test coverage for new actionSettings field including JSON fixture and assertions |
| docs/Using-Operations-Service.md | Updated documentation to describe the new actionSettings property in pre-approval buttons |
| docs/Migration-2.4.md | Updated example JSON to include actionSettings in button element |
# Conflicts: # docs/Using-Operations-Service.md
kober32
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#223