Remove icon from element + alert + button#226
Merged
Hopsaheysa merged 1 commit intodevelopfrom Nov 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the PreApprovalElement class hierarchy by removing the icon property from the base class and its subclasses (PreApprovalElementButton and PreApprovalElementAlert), while retaining it only in PreApprovalElementListItem where it is actually used and serialized.
Key changes:
- Removed the
iconparameter fromPreApprovalElementbase class constructor - Removed the
iconparameter fromPreApprovalElementButtonandPreApprovalElementAlertsubclasses - Made the
iconproperty a proper field inPreApprovalElementListItemwith@SerializedNameannotation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PreApprovalElement.kt | Removed unused icon field from base class and subclasses where it wasn't needed; made it a proper serialized field only in PreApprovalElementListItem |
| PreApprovalElementTypeAdapter.kt | Updated constructor calls to remove the icon parameter for PreApprovalElementAlert, PreApprovalElementButton, and PreApprovalElement |
...main/java/com/wultra/android/mtokensdk/api/operation/model/preapproval/PreApprovalElement.kt
Show resolved
Hide resolved
kober32
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#225
icon String removed from Element + Alert + Button
kept in ListItem
docs + mig. guide were correct