Improve logging of the PreApprovalElement decoding#228
Merged
Hopsaheysa merged 1 commit intodevelopfrom Nov 6, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves error logging for JSON deserialization failures in operation UI data parsing and adds test coverage for malformed JSON structures.
- Enhanced error visibility by upgrading log levels from warning/debug to error for JSON deserialization failures
- Added test coverage for incorrect JSON structure handling (object instead of array for
elements)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| library/src/main/java/com/wultra/android/mtokensdk/api/operation/utils/JsonHelpers.kt | Upgraded log levels from w/d to e for type mismatches and deserialization failures, and improved null handling with early returns |
| library/src/androidTest/java/OperationUIDataTests.kt | Added test case for Screen3 with incorrect elements structure to verify graceful error handling and null fallback behavior |
kober32
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#227