Skip to content

feat: improve arena implementation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensneuse merged 10 commits into from
Oct 10, 2025
Merged

feat: improve arena implementation #12

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6b1e34e
chore: cleanup old arena
jensneuse Sep 29, 2025
66e2839
Merge branch 'master' into feat/improve-arena-handling
jensneuse Sep 29, 2025
56b3fd1
chore: merge main
jensneuse Sep 29, 2025
7d4d045
chore: remove cache
jensneuse Sep 29, 2025
557ce21
chore: remove cache
jensneuse Sep 29, 2025
2616cd7
feat: better arena implementation
jensneuse Oct 9, 2025
1193498
refactor: fix lint issues, update linter
jensneuse Oct 9, 2025
f1b4b27
chore: update CI configuration and dependencies
jensneuse Oct 9, 2025
5bcda71
test: add unit test for Del method with nil arena handling
jensneuse Oct 9, 2025
d990a3d
test: add benchmarks for JSON parsing and marshalling performance
jensneuse Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,27 @@ on:
push:
branches:
- master

permissions:
contents: read

jobs:
test:
name: Build and test (go ${{ matrix.go }} / ${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
matrix:
go: [ '1.21' ]
go: [ '1.25' ]
os: [ubuntu-latest, windows-latest]
steps:
- name: Set git to use LF
run: |
git config --global core.autocrlf false
git config --global core.eol lf
- name: Check out code into the Go module directory
uses: actions/checkout@v3
uses: actions/checkout@v5
- name: Set up Go ${{ matrix.go }}
uses: actions/setup-go@v4
uses: actions/setup-go@v6
with:
go-version: ^${{ matrix.go }}
id: go
Expand All @@ -32,20 +36,17 @@ jobs:
run: go test -v ./... -race

lint:
name: Linters
name: lint
runs-on: ubuntu-latest
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v3
- name: Set up Go 1.21
uses: actions/setup-go@v4
- uses: actions/checkout@v5
- uses: actions/setup-go@v6
with:
go-version: 1.21
- name: Run linters
uses: golangci/golangci-lint-action@v3
go-version: stable
- name: golangci-lint
uses: golangci/golangci-lint-action@v8
with:
version: v1.55.2
args: --timeout=3m
version: v2.5.0
ci:
name: CI Success
if: ${{ always() }}
Expand Down
128 changes: 0 additions & 128 deletions arena.go
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions arena_test.go
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions arena_timing_test.go
View file
Open in desktop

This file was deleted.

7 changes: 5 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
module github.com/wundergraph/astjson

go 1.21
go 1.25

require github.com/stretchr/testify v1.9.0
require (
github.com/stretchr/testify v1.11.1
github.com/wundergraph/go-arena v0.0.0-20251008210416-55cb97e6f68f
)

require (
github.com/davecgh/go-spew v1.1.1 // indirect
Expand Down
6 changes: 4 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
github.com/wundergraph/go-arena v0.0.0-20251008210416-55cb97e6f68f h1:5snewyMaIpajTu4wj22L/DgrGimICqXtUVjkZInBH3Y=
github.com/wundergraph/go-arena v0.0.0-20251008210416-55cb97e6f68f/go.mod h1:ROOysEHWJjLQ8FSfNxZCziagb7Qw2nXY3/vgKRh7eWw=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
Expand Down
Loading