Skip to content

chore(infra): remove --platform build flags from Dockerfiles #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −11
Open

chore(infra): remove --platform build flags from Dockerfiles #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dd69c8
fix(infra): ensure base images use target platform
joornby-angel Sep 26, 2025
a748adf
Merge branch 'main' into feature/docker_target_platform_builds
joornby-angel Oct 7, 2025
b5ef11a
fix(infra): maintain build host builder, use target in final stage
joornby-angel Oct 7, 2025
c75adf0
Merge branch 'main' into feature/docker_target_platform_builds
joornby-angel Oct 22, 2025
8d3be5a
Merge branch 'main' into feature/docker_target_platform_builds
joornby-angel Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admission-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ RUN pnpm run --filter=./admission-server build
# Deploy
RUN pnpm --filter=./admission-server --prod deploy pruned

FROM --platform=${BUILDPLATFORM} node:lts-slim
FROM --platform=${TARGETPLATFORM} node:lts-slim

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion cdn-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN pnpm run --filter=./cdn-server/cdn --filter=./cdn-server build
# Deploy
RUN pnpm --filter=./cdn-server --prod deploy pruned

FROM --platform=${BUILDPLATFORM} node:lts-slim
FROM --platform=${TARGETPLATFORM} node:lts-slim

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion controlplane/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN curl -fsSL -o /usr/local/bin/dbmate https://github.com/amacneil/dbmate/relea
# Deploy
RUN pnpm --filter=./controlplane --prod deploy pruned

FROM --platform=${BUILDPLATFORM} node:lts-alpine
FROM --platform=${TARGETPLATFORM} node:lts-alpine

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion graphqlmetrics/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN make test
# Build router
RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -trimpath -ldflags "-extldflags -static -X github.com/wundergraph/cosmo/graphqlmetrics/core.Version=${VERSION}" -a -o graphqlmetrics cmd/main.go

FROM --platform=${BUILDPLATFORM} gcr.io/distroless/base-debian12
FROM --platform=${TARGETPLATFORM} gcr.io/distroless/base-debian12

COPY --from=builder /app/graphqlmetrics /graphqlmetrics
COPY --from=builder /app/migrations /migrations
Expand Down
4 changes: 2 additions & 2 deletions keycloak/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ COPY ./theme .

RUN ./build.sh

FROM --platform=${BUILDPLATFORM} bitnamilegacy/keycloak:26.2.5
FROM --platform=${TARGETPLATFORM} bitnamilegacy/keycloak:26.2.5

COPY --from=0 /app/target/*.jar /opt/bitnami/keycloak/providers/

Expand All @@ -22,4 +22,4 @@ COPY --from=0 /app/target/*.jar /opt/bitnami/keycloak/providers/
RUN /opt/bitnami/keycloak/bin/kc.sh build --db=postgres --metrics-enabled true --health-enabled true --http-relative-path "/"

EXPOSE 8080
EXPOSE 8443
EXPOSE 8443
2 changes: 1 addition & 1 deletion otelcollector/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ RUN ./ocb --config otelcol-builder.yaml \
&& chmod +x /app/otelcol-dev/otelcol \
&& /app/otelcol-dev/otelcol --version

FROM --platform=${BUILDPLATFORM} golang:1.25
FROM --platform=${TARGETPLATFORM} golang:1.25

COPY ./otel-config.yaml /etc/otel-config.yaml
COPY --from=builder /app/otelcol-dev/otelcol /otelcol
Expand Down
4 changes: 2 additions & 2 deletions router/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
-X 'github.com/wundergraph/cosmo/router/core.Date=${DATE}'" \
-a -o router cmd/router/main.go

FROM --platform=${BUILDPLATFORM} gcr.io/distroless/base-debian12:nonroot AS nonroot
FROM --platform=${TARGETPLATFORM} gcr.io/distroless/base-debian12:nonroot AS nonroot

# nonroot user uid
USER 65532
Expand All @@ -45,7 +45,7 @@ CMD ["/router"]

EXPOSE 3002

FROM --platform=${BUILDPLATFORM} gcr.io/distroless/base-debian12
FROM --platform=${TARGETPLATFORM} gcr.io/distroless/base-debian12

COPY --from=builder /app/router /router

Expand Down
4 changes: 2 additions & 2 deletions studio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ RUN pnpm buf generate --template buf.ts.gen.yaml

RUN pnpm run --filter=./connect --filter=./shared --filter=./studio --filter=./composition build

FROM --platform=${BUILDPLATFORM} node:lts-alpine
FROM --platform=${TARGETPLATFORM} node:lts-alpine

WORKDIR /app

Expand All @@ -68,4 +68,4 @@ EXPOSE 3000
ENV PORT=3000
ENV HOSTNAME=localhost

CMD ["node", "./studio/server.js"]
CMD ["node", "./studio/server.js"]