Skip to content

feat(router): permit log service name to be configured via env var #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −5
Draft

feat(router): permit log service name to be configured via env var #2276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabbc51
feat(router): permit log service name to be configured via env var
brokenpip3 Oct 14, 2025
00864ee
Merge branch 'main' into add-log-service-name-config
brokenpip3 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions router/cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ import (
)

var (
overrideEnvFlag = flag.String("override-env", os.Getenv("OVERRIDE_ENV"), "Path to .env file to override environment variables")
routerVersion = flag.Bool("version", false, "Prints the version and dependency information")
pprofListenAddr = flag.String("pprof-addr", os.Getenv("PPROF_ADDR"), "Address to listen for pprof requests. e.g. :6060 for localhost:6060")
pyroscopeAddr = flag.String("pyroscope-addr", os.Getenv("PYROSCOPE_ADDR"), "Address to use for pyroscope continuous profiling. e.g. http://localhost:4040")
overrideEnvFlag = flag.String("override-env", os.Getenv("OVERRIDE_ENV"), "Path to .env file to override environment variables")
routerVersion = flag.Bool("version", false, "Prints the version and dependency information")
pprofListenAddr = flag.String("pprof-addr", os.Getenv("PPROF_ADDR"), "Address to listen for pprof requests. e.g. :6060 for localhost:6060")
pyroscopeAddr = flag.String("pyroscope-addr", os.Getenv("PYROSCOPE_ADDR"), "Address to use for pyroscope continuous profiling. e.g. http://localhost:4040")
logServiceName = flag.String("log-service-name", os.Getenv("LOG_SERVICE_NAME"), "Service name to use in logs, defaults to @wundergraph/router")

memProfilePath = flag.String("memprofile", "", "Path to write memory profile. Memory is a snapshot taken at the time the program exits")
cpuProfilePath = flag.String("cpuprofile", "", "Path to write cpu profile. CPU is measured from when the program starts until the program exits")
Expand Down Expand Up @@ -90,9 +91,14 @@ func Main() {

logLevelAtomic := zap.NewAtomicLevelAt(result.Config.LogLevel)

serviceName := *logServiceName
Copy link
Contributor

@StarpTech StarpTech Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead off having this as a flag, it would be more useful to support it in the config file. For this, you need to update

cosmo/router/pkg/config/config.go

Line 1006 in d6a443e

type Config struct {

There you can also enforce the default, make it available as ENV + make it required.

Copy link
Author

@brokenpip3 brokenpip3 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it make sense, ty, let me do it :)

if serviceName == "" {
serviceName = "@wundergraph/router"
}

baseLogger := logging.New(!result.Config.JSONLog, result.Config.DevelopmentMode, result.Config.AccessLogs.AddStacktrace, logLevelAtomic).
With(
zap.String("service", "@wundergraph/router"),
zap.String("service", serviceName),
zap.String("service_version", core.Version),
)

Expand Down