-
Notifications
You must be signed in to change notification settings - Fork 202
chore: update CODEOWNERS #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update CODEOWNERS #2374
Conversation
… composition-go directories
WalkthroughUpdates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/CODEOWNERS (2)
1-1: Optional: fix minor typo in top-level commentThe word “expections” in the header comment appears to be a typo; consider changing it to “exceptions” for clarity.
9-9: Optional: remove duplicate owner on/cli/line
@endigmaappears twice on the/cli/entry. It’s harmless but redundant; consider keeping it only once.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
.github/CODEOWNERS (2)
10-11: Composition ownership updates look correctThe additions of
@thisisnithinto/composition/and/composition-go/are syntactically valid and consistent with the rest of the CODEOWNERS file and the stated PR goal. No further changes needed here.
15-17: Confirm reduced owner sets for infra/metrics/helm/otel pathsThe updated entries for
/graphqlmetrics/,/helm/,/infrastructure/, and/otelcollector/are syntactically valid and still have clear ownership, but they significantly narrow the responsible set of reviewers. Please just confirm this reduced owner list matches the agreement you reached with the team.Also applies to: 19-19
StarpTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist