Conversation
WalkthroughRemoves a cluster-mode test case from the rate limit test suite: the test "should successfully use auth from later url if no auth in first urls" and its surrounding commented block were deleted, leaving no other functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@router-tests/ratelimit_test.go`:
- Around line 711-714: The test name "should successfully use auth from later
url if no auth in first urls" is misleading because the cluster implementation
(rediscloser.go) only uses credentials from the first URL and strips creds from
secondary URLs; update the table entry that defines name and clusterUrlSlice
(the case with []string{"redis://localhost:7003", "rediss://localhost:7001",
"rediss://cosmo:test@localhost:7002"}) to either (a) rename the test to reflect
that auth comes from explicit Username/Password or from the first URL (e.g.,
"uses explicit Username/Password when secondary URLs contain credentials") or
(b) remove the case entirely if you intended to test extracting auth from later
URLs but that behavior is unsupported; ensure the test assertions match the
actual behavior (i.e., credentials are provided via Username/Password, not
parsed from later URLs).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
router-tests/ratelimit_test.go
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-01T20:39:16.113Z
Learnt from: SkArchon
Repo: wundergraph/cosmo PR: 2252
File: router-tests/telemetry/telemetry_test.go:9684-9693
Timestamp: 2025-10-01T20:39:16.113Z
Learning: Repo preference: In router-tests/telemetry/telemetry_test.go, keep strict > 0 assertions for request.operation.*Time (parsingTime, normalizationTime, validationTime, planningTime) in telemetry-related tests; do not relax to >= 0 unless CI flakiness is observed.
Applied to files:
router-tests/ratelimit_test.go
📚 Learning: 2026-01-06T12:37:21.521Z
Learnt from: asoorm
Repo: wundergraph/cosmo PR: 2379
File: router/pkg/connectrpc/operation_registry_test.go:381-399
Timestamp: 2026-01-06T12:37:21.521Z
Learning: In Go code (Go 1.25+), prefer using sync.WaitGroup.Go(func()) to run a function in a new goroutine, letting the WaitGroup manage Add/Done automatically. Avoid manual wg.Add(1) followed by go func() { defer wg.Done(); ... }() patterns. Apply this guidance across all Go files in the wundergraph/cosmo repository where concurrency is used.
Applied to files:
router-tests/ratelimit_test.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: image_scan
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./events)
- GitHub Check: build_push_image (nonroot)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2453 +/- ##
===========================================
+ Coverage 37.66% 61.37% +23.71%
===========================================
Files 769 229 -540
Lines 114353 23839 -90514
Branches 7869 0 -7869
===========================================
- Hits 43066 14632 -28434
+ Misses 70928 7971 -62957
- Partials 359 1236 +877 🚀 New features to boost your workflow:
|
…ppening and not documented, so no need for it at all
…is-clusterurlslice
This test was left there because failing after the last refactor, waiting for a check. I've checked and find out that:
So I just removed the test.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist