fix: planner fixes for abstract selection rewriter, node selection rules

[devsergiy]

fixes ENG-8653
fixes ENG-8584
fixes ENG-8697

Summary by CodeRabbit

• Chores
  • Updated an internal build dependency to a newer patch-level pre-release across build configurations.
  • Ensures more reproducible builds and incorporates minor upstream fixes without any behavioral or public API changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
• I have read the Contributors Guide.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• router/go.sum is excluded by !**/*.sum

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Bumps github.com/wundergraph/graphql-go-tools/v2 in router/go.mod and router-tests/go.mod from v2.0.0-rc.242 to v2.0.0-rc.243.

Changes

Cohort / File(s)	Summary
Dependency Version Update router/go.mod, router-tests/go.mod	Updated github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.242 to v2.0.0-rc.243 (pre-release patch bump)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix: planner fixes for parent entity jumps and unique nodes selections #2044: Updates the same github.com/wundergraph/graphql-go-tools/v2 dependency version in router-related go.mod files.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'fix: planner fixes for abstract selection rewriter, node selection rules' claims to fix planner issues, but the actual changeset only updates dependency versions in go.mod files with no code changes.	The title should accurately reflect the actual changes—dependency upgrades for graphql-go-tools v2 from rc.242 to rc.243—rather than implying planner fixes that are not present in the changeset.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@router-tests/go.mod`:
- Line 29: The go.mod entry for module
github.com/wundergraph/graphql-go-tools/v2 pins a pseudo-version (bb94a8ad51f6);
verify the router query-planning behavior with this commit, then replace the
pseudo-version with a proper tagged release (e.g., v2.0.0-rc.243) in go.mod,
update the module via `go get
github.com/wundergraph/graphql-go-tools/v2@v2.0.0-rc.243` (or the verified tag),
run `go mod tidy` and the test suite to confirm no regressions, and commit the
updated go.mod and go.sum.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae35b80 and b1cef0d.

⛔ Files ignored due to path filters (2)

• router-tests/go.sum is excluded by !**/*.sum
• router/go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• router-tests/go.mod
• router/go.mod

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: StarpTech
Repo: wundergraph/cosmo PR: 2157
File: router-tests/go.mod:16-16
Timestamp: 2025-08-20T22:13:25.222Z
Learning: github.com/mark3labs/mcp-go v0.38.0 has regressions and should not be used in the wundergraph/cosmo project. v0.36.0 is the stable version that should be used across router-tests and other modules.

Learnt from: SkArchon
Repo: wundergraph/cosmo PR: 2252
File: router-tests/telemetry/telemetry_test.go:9684-9693
Timestamp: 2025-10-01T20:39:16.113Z
Learning: Repo preference: In router-tests/telemetry/telemetry_test.go, keep strict > 0 assertions for request.operation.*Time (parsingTime, normalizationTime, validationTime, planningTime) in telemetry-related tests; do not relax to >= 0 unless CI flakiness is observed.

📚 Learning: 2025-08-20T22:13:25.222Z

Learnt from: StarpTech
Repo: wundergraph/cosmo PR: 2157
File: router-tests/go.mod:16-16
Timestamp: 2025-08-20T22:13:25.222Z
Learning: github.com/mark3labs/mcp-go v0.38.0 has regressions and should not be used in the wundergraph/cosmo project. v0.36.0 is the stable version that should be used across router-tests and other modules.

Applied to files:

• router/go.mod
• router-tests/go.mod

📚 Learning: 2026-01-05T11:53:58.709Z

Learnt from: asoorm
Repo: wundergraph/cosmo PR: 2438
File: router-tests/go.mod:15-15
Timestamp: 2026-01-05T11:53:58.709Z
Learning: For mcp-go dependency in wundergraph/cosmo, patch releases may not have formal release notes published. Tag diffs should be reviewed to verify patch-level changes contain no API surface changes or breaking behavior before adopting new patch versions.

Applied to files:

• router/go.mod
• router-tests/go.mod

📚 Learning: 2025-09-24T12:54:00.765Z

Learnt from: endigma
Repo: wundergraph/cosmo PR: 2222
File: router-tests/websocket_test.go:2238-2302
Timestamp: 2025-09-24T12:54:00.765Z
Learning: The wundergraph/cosmo project uses Go 1.25 (Go 1.23+ minimum), so fmt.Appendf and other newer Go standard library functions are available and can be used without compatibility concerns.

Applied to files:

• router/go.mod
• router-tests/go.mod

📚 Learning: 2025-09-24T12:54:00.765Z

Learnt from: endigma
Repo: wundergraph/cosmo PR: 2222
File: router-tests/websocket_test.go:2238-2302
Timestamp: 2025-09-24T12:54:00.765Z
Learning: The wundergraph/cosmo project uses Go 1.25 (Go 1.25 minimum), so fmt.Appendf and other newer Go standard library functions are available and can be used without compatibility concerns.

Applied to files:

• router/go.mod
• router-tests/go.mod

📚 Learning: 2025-11-19T15:13:57.821Z

Learnt from: dkorittki
Repo: wundergraph/cosmo PR: 2273
File: router/core/graphql_handler.go:0-0
Timestamp: 2025-11-19T15:13:57.821Z
Learning: In the Cosmo router (wundergraph/cosmo), error handling follows a two-phase pattern: (1) Prehandler phase handles request parsing, validation, and setup errors using `httpGraphqlError` and `writeOperationError` (in files like graphql_prehandler.go, operation_processor.go, parse_multipart.go, batch.go); (2) Execution phase handles resolver execution errors using `WriteError` in GraphQLHandler.ServeHTTP. Because all `httpGraphqlError` instances are caught in the prehandler before ServeHTTP is invoked, any error type checks for `httpGraphqlError` in the execution-phase WriteError method are unreachable code.

Applied to files:

• router-tests/go.mod

📚 Learning: 2025-08-15T10:21:45.838Z

Learnt from: StarpTech
Repo: wundergraph/cosmo PR: 2142
File: helm/cosmo/Chart.yaml:0-0
Timestamp: 2025-08-15T10:21:45.838Z
Learning: In the WunderGraph Cosmo project, helm chart version upgrades and README badge synchronization are handled in separate helm release PRs, not in the initial version bump PRs.

Applied to files:

• router-tests/go.mod

🔇 Additional comments (1)

router/go.mod (1)

34-34: Temporary dependency version - ensure consistent release plan.

This module correctly uses the same pseudo-version as router-tests/go.mod. The same verification and release planning concerns apply here: ensure the commit includes the expected planner fixes and plan to replace with a proper tagged release before merging to main.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[github-actions]

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-bb33aac2c8eb1fda5db511753d36e339e01e91c4-nonroot

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.02%. Comparing base (d0cbf9c) to head (fffb2d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2457       +/-   ##
===========================================
+ Coverage   29.11%   61.02%   +31.90%     
===========================================
  Files         127      229      +102     
  Lines       11144    23853    +12709     
  Branches      251        0      -251     
===========================================
+ Hits         3245    14556    +11311     
- Misses       7897     8045      +148     
- Partials        2     1252     +1250     

see 356 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.