fix: if an error is caught, exit immediately#2478
Merged
JivusAyrus merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
…hanging work is not acceptable.
Contributor
WalkthroughThe catch block in the CLI's main entry point now awaits the telemetry shutdown function before exiting, rather than immediately setting the exit code. This ensures telemetry is properly flushed before the process terminates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
===========================================
- Coverage 63.20% 28.34% -34.87%
===========================================
Files 296 127 -169
Lines 41480 11144 -30336
Branches 4312 243 -4069
===========================================
- Hits 26219 3159 -23060
+ Misses 15239 7981 -7258
+ Partials 22 4 -18
🚀 New features to boost your workflow:
|
JivusAyrus
approved these changes
Jan 30, 2026
maxbol
pushed a commit
to maxbol/cosmo
that referenced
this pull request
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist