feat: set operation name also with persistent queries#2480
Merged
Conversation
Contributor
WalkthroughA behavioral enhancement to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
+ Coverage 1.50% 61.55% +60.05%
==========================================
Files 292 229 -63
Lines 46816 23883 -22933
Branches 431 0 -431
==========================================
+ Hits 703 14702 +13999
+ Misses 45830 7941 -37889
- Partials 283 1240 +957
🚀 New features to boost your workflow:
|
…s-for-persisted-queries
endigma
approved these changes
Feb 2, 2026
maxbol
pushed a commit
to maxbol/cosmo
that referenced
this pull request
Feb 12, 2026
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client send a persisted query without the operation name, we should fetch the operation name from the query, to make the analytics more usable.
Before this PR, when the normalized cache is hit, the operation name is not properly set and the metrics and trace have only the operation id.
Summary by CodeRabbit
Release Notes
Bug Fixes
Tests
Checklist