Skip to content

fix: change failed request query parse log to warn instead of error#2743

Merged
alepane21 merged 1 commit intomainfrom
ale/failed-parse-query-log-as-warn
Apr 7, 2026
Merged

fix: change failed request query parse log to warn instead of error#2743
alepane21 merged 1 commit intomainfrom
ale/failed-parse-query-log-as-warn

Conversation

@alepane21
Copy link
Copy Markdown
Contributor

@alepane21 alepane21 commented Apr 7, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Adjusted logging level for query parameter parsing to better reflect error severity.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/docs-website.
  • I have read the Contributors Guide.

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@github-actions github-actions bot added the router label Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f3afbd0a-1a6a-4957-871d-1896297cdb62

📥 Commits

Reviewing files that changed from the base of the PR and between 2326f9c and 1819e03.

📒 Files selected for processing (1)
  • router/internal/requestlogger/requestlogger.go

Walkthrough

A single log level adjustment in the request logger module changes how query parameter parsing failures are reported, downgrading from error to warning severity. No functional logic or control flow modifications are made.

Changes

Cohort / File(s) Summary
Logging Level Adjustment
router/internal/requestlogger/requestlogger.go		 Changed log level from Error to Warn when URL query parameter parsing fails; error suppression and request field building logic remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: converting a log level from error to warn for failed query parsing, which matches the changeset exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-9b1f793185e1e0bb6f5e4a9bedacdd62aaa0dca1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-9b1f793185e1e0bb6f5e4a9bedacdd62aaa0dca1-nonroot

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.46%. Comparing base (65e05e3) to head (1819e03).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
router/internal/requestlogger/requestlogger.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files         251      251           
  Lines       26767    26767           
=======================================
  Hits        16987    16987           
- Misses       8414     8416    +2     
+ Partials     1366     1364    -2
Files with missing lines Coverage Δ
router/internal/requestlogger/requestlogger.go 93.49% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StarpTech
StarpTech approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alepane21 alepane21 merged commit 09e4653 into main Apr 7, 2026
37 checks passed
@alepane21 alepane21 deleted the ale/failed-parse-query-log-as-warn branch April 7, 2026 12:28
@coderabbitai coderabbitai bot mentioned this pull request Apr 7, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StarpTech StarpTech StarpTech approved these changes

@Noroth Noroth Awaiting requested review from Noroth Noroth is a code owner

@devsergiy devsergiy Awaiting requested review from devsergiy devsergiy is a code owner

@jensneuse jensneuse Awaiting requested review from jensneuse jensneuse is a code owner

@endigma endigma Awaiting requested review from endigma endigma is a code owner

@SkArchon SkArchon Awaiting requested review from SkArchon SkArchon is a code owner

Assignees

No one assigned

Labels

router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alepane21 @StarpTech