Skip to content

fix: change failed request query parse log to warn instead of error #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alepane21 merged 1 commit into from
Apr 7, 2026
+1 −1
Merged

fix: change failed request query parse log to warn instead of error #2743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion router/internal/requestlogger/requestlogger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ func (al *accessLogger) getRequestFields(r *http.Request, logger *zap.Logger) []
if err != nil {
// We ignore logging the err since it could leak partial sensitive data
// such as %pa from "%password"
logger.Error("Failed to parse query parameters")
logger.Warn("Failed to parse query parameters")
// Since we wanted to ignore some values but we cant parse it
// we default to a safer skip all
query = ""
Expand Down
Loading