fix(router): prevent data races in batched validation error responses - #3217
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe router and router-tests Go modules update ChangesGraphQL tools dependency update
Priority: ➖ Normal — Schedule the router dependency pin because it addresses data races in batched validation error responses. Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The router and router-tests modules now use graphql-go-tools v2.20.2 to address pooled-walker validation races. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
- Coverage 66.99% 62.80% -4.19%
==========================================
Files 778 266 -512
Lines 63328 31575 -31753
Branches 7847 0 -7847
==========================================
- Hits 42425 19832 -22593
+ Misses 18193 10191 -8002
+ Partials 2710 1552 -1158 🚀 New features to boost your workflow:
|
…t-processing-validation-walker
Summary
Update router and router-tests to go-tools v2.20.2 to prevent validation error paths from racing with pooled walker reuse during batched requests.
Closes #3216
Tests
Verified with Go 1.25.14:
go mod tidy -diff.-race(2,170 tests, 7 skipped).-race(190 tests).Summary by CodeRabbit