Fix and improve debugging for relative addresses#11
Open
binary-sequence wants to merge 1 commit intowutka:mainfrom
Open
Fix and improve debugging for relative addresses#11binary-sequence wants to merge 1 commit intowutka:mainfrom
binary-sequence wants to merge 1 commit intowutka:mainfrom
Conversation
binary-sequence
force-pushed
the
fix-debug-rel-addr
branch
from
1fd4b3a to
ed384dc
Compare
Sample program to reproduce:
`0: A9 FF 30 FC`
```
* = $0000
0000 A9 FF LOOP LDA #$FF
0002 30 FC BMI LOOP
.END
```
1. Type in program
2. Start debugger (CTRL-D)
3. See disassembled output for `30 FC`
Before this fix (wrong)
```
pc = 0002 a=ff x=00 y=01 sp=fd status=N C
0002: 30 fc bmi $0100
```
After this fix (right)
```
pc = 0002 a=ff x=00 y=01 sp=fd status=N C
0002: 30 fc bmi -4 ; $0000
```
binary-sequence
force-pushed
the
fix-debug-rel-addr
branch
from
ed384dc to
ebc4212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample program to reproduce:
0: A9 FF 30 FC30 FCBefore this fix (wrong)
After this fix (right)