feat(CD): expose more attributes for CD device#758
Open
FrancYescO wants to merge 11 commits intowuwentao:masterfrom
Open
feat(CD): expose more attributes for CD device#758FrancYescO wants to merge 11 commits intowuwentao:masterfrom
FrancYescO wants to merge 11 commits intowuwentao:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request exposes additional device attributes for CD-type devices (Heat Pump Water Heaters) in the Midea AC LAN integration. The changes add sensor capabilities to monitor various operational states and system components of the water heater.
Changes:
- Added 15 new translation entries for binary sensors and regular sensors in the English translation file
- Configured 15 new entity definitions in the device configuration for CD (Heat Pump Water Heater) devices
- Changed the water heater icon from "mdi:heat-pump" to "mdi:water-boiler"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| custom_components/midea_ac_lan/translations/en.json | Added English translations for newly exposed sensor attributes including mute controls, smart grid, multi terminal, electric heat components, water pump, and other system components |
| custom_components/midea_ac_lan/midea_devices.py | Configured entity definitions for new CD device attributes with appropriate types, icons, device classes, and translations; updated water heater icon |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.5 → v0.14.10](astral-sh/ruff-pre-commit@v0.14.5...v0.14.10) - [github.com/commitizen-tools/commitizen: v4.10.0 → v4.11.0](commitizen-tools/commitizen@v4.10.0...v4.11.0) - [github.com/asottile/pyupgrade: v3.21.1 → v3.21.2](asottile/pyupgrade@v3.21.1...v3.21.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Simone Chemelli <simone.chemelli@gmail.com>
updates: - [github.com/commitizen-tools/commitizen: v4.11.0 → v4.11.1](commitizen-tools/commitizen@v4.11.0...v4.11.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Update custom_components/midea_ac_lan/midea_devices.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update custom_components/midea_ac_lan/midea_devices.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update custom_components/midea_ac_lan/midea_devices.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
thanks for your PR. |
wuwentao
changed the title
Owner
|
thanks for your PR, could you help to update the CD device docs ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
expose more attributes for CD
Reason & Detail
expose more attributes for CD
Related issue
#734
in conjuction with midea-lan/midea-local#420