Fix autocompletion scoping with has_* through relations

[adamruzicka]

No description provided.

[adamruzicka]

Nope, hold on, not quite it

[adamruzicka]

This could do it, but it changes the autocomplete's behaviour a bit.

An example from Foreman - I have a Host with:

• has_many :interfaces
• has_one :primary_interface with where(primary: true) scope
• has_one :domain, through: :primary_interface

Before this (and the previous scope change), calling Host.complete_for('domain = ') offered all domains in existence. After this change, it only offers domains, which are actually linked to a primary interface of a host.

[ofedoren]

Thanks, @adamruzicka ! I've tested it a bit and it seems to work per description, also I've noticed that in the context of Foreman if I do Host.complete_for('location = ') it would suggest only locations which have a host. I'd say that's fine, but some might find it as a bug, what's your take on this?

Overall ACK from me.

[adamruzicka]

I'd say that's fine, but some might find it as a bug, what's your take on this?

I'd say having autocomplete offer you options which yield no results when evaluated is a bit pointless. So while it might be viewed as a bug, I'd say this new behaviour makes more sense.

[ofedoren]

I'd say that's fine, but some might find it as a bug, what's your take on this?

I'd say having autocomplete offer you options which yield no results when evaluated is a bit pointless. So while it might be viewed as a bug, I'd say this new behaviour makes more sense.

We should somehow propagate this take to the users of the library, like a heads up.

[adamruzicka]

I updated the changelog, once this goes in I'll update the wiki. Not sure if there's anything else that can be done