Conversation
- Update openjdk dependency from openjdk@21 to openjdk@25 - Update Java version references from 21 to 25 in formula - Changes applied to both wvlet.rb and wvlet.rb.template 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical dependency update, moving the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to upgrade the OpenJDK dependency from version 21 to 25. While the changes are consistent across the formula and template files, there is a critical issue with the chosen dependency. The openjdk@25 formula does not currently exist in Homebrew's core repository, which will cause the installation to fail for users. My review includes comments on both modified files highlighting this issue and suggesting alternative approaches, such as depending on the latest available openjdk formula or waiting for openjdk@25 to become available.
|
|
||
| depends_on "openjdk@21" | ||
| depends_on "openjdk@25" |
There was a problem hiding this comment.
The dependency openjdk@25 is not a valid Homebrew formula at this time. The homebrew-core tap does not provide an openjdk@25 formula, which will cause brew install to fail for users. Please use an available formula, such as openjdk for the latest release or openjdk@21 for the LTS version. If Java 25 is a strict requirement, this change should be postponed until an openjdk@25 formula is officially available.
|
|
||
| depends_on "openjdk@21" | ||
| depends_on "openjdk@25" |
There was a problem hiding this comment.
The dependency openjdk@25 is not a valid Homebrew formula at this time. The homebrew-core tap does not provide an openjdk@25 formula, which will cause brew install to fail for users. Please use an available formula, such as openjdk for the latest release or openjdk@21 for the LTS version. If Java 25 is a strict requirement, this change should be postponed until an openjdk@25 formula is officially available.
| libexec.install Dir["*"] | ||
| bin.install Dir[libexec/"bin/*"] | ||
| bin.env_script_all_files(libexec/"bin", JAVA_HOME: Language::Java.overridable_java_home_env("21")[:JAVA_HOME]) | ||
| bin.env_script_all_files(libexec/"bin", JAVA_HOME: Language::Java.overridable_java_home_env("25")[:JAVA_HOME]) |
There was a problem hiding this comment.
This line now references Java version "25". This will fail if a Java 25 installation cannot be found. This is contingent on the openjdk@25 dependency being available and installable, which is currently not the case as pointed out in the comment for line 9.
| libexec.install Dir["*"] | ||
| bin.install Dir[libexec/"bin/*"] | ||
| bin.env_script_all_files(libexec/"bin", JAVA_HOME: Language::Java.overridable_java_home_env("21")[:JAVA_HOME]) | ||
| bin.env_script_all_files(libexec/"bin", JAVA_HOME: Language::Java.overridable_java_home_env("25")[:JAVA_HOME]) |
There was a problem hiding this comment.
This line now references Java version "25". This will fail if a Java 25 installation cannot be found. This is contingent on the openjdk@25 dependency being available and installable, which is currently not the case as pointed out in the comment for line 9.
1 participant
Summary
This PR upgrades the OpenJDK dependency from version 21 to version 25, updating both the main formula and template files.
Changes
openjdk@21toopenjdk@25in dependency declaration21to25in the install methodwvlet.rbandwvlet.rb.templateTest plan
🤖 Generated with Claude Code