Skip to content

Nikola8#8

Merged
swt2c merged 7 commits intowxWidgets:masterfrom
DietmarSchwertberger:NIKOLA8
Feb 9, 2025
Merged

Nikola8#8
swt2c merged 7 commits intowxWidgets:masterfrom
DietmarSchwertberger:NIKOLA8

Conversation

@DietmarSchwertberger
Copy link
Contributor

A first attempt.
I have removed all requirements except Nikola itself.

I have tested with Python 3.12 and the current Nikola 8.3.1.
The result looks reasonable close to the current website version. I'm just missing the number of comments.

The conf.py is a merge from the old version with the currrent template from Nikola.

The wxPython theme uses bootstrap3 as base. I tried bootstrap4, but then the navigation popups were not formatted correctly.
To install nikola theme -i bootstrap3 is required. Is it possible to do this automatically?
I would have included a local copy into the repository, but .gitignore has some theme related entries:

themes/base/
themes/bootstrap3/
themes/bootswatch/

Maybe, Robin did use local, modified copies. Should I remove the ignore entries and include a bootstrap3 copy?

The modifications include a local version of the listing.plugin to avoid the empty lineanchors
(at plugins/compile/rest/listing.plugin, the utils.NikolaPygmentsHTML argument anchor_ref is commented out).
This should fix the accessibility problems with the code samples wxWidgets/Phoenix#2677
It can be removed once Pygments PR pygments/pygments#2848 is merged into a release.

@DietmarSchwertberger
Copy link
Contributor Author

The category descriptions seem to be case sensitive. They're now News and Blog.

@swt2c swt2c closed this Feb 6, 2025
@swt2c swt2c reopened this Feb 6, 2025
@swt2c
Copy link
Collaborator

swt2c commented Feb 6, 2025

Hey @DietmarSchwertberger thanks for your work on this.

I added a deploy preview Github Action that will attempt to build the site and deploy it to a preview location so we can easily review it. It seems the build is running into an error (see the failing check).

mako.exceptions.TopLevelLookupException: Can't locate template for uri 'homepage_postlist.tmpl'

Also to answer some of your earlier questions: if you need to add nikola theme -i bootstrap3 you can add it to .github/actions/build-website/action.yml (you will probably have to merge or rebase to see this file as I just added it).

@DietmarSchwertberger
Copy link
Contributor Author

Thanks. I will try to add the action for the bootstrap3 installation.
The failing check is most likely a secondary effect.
I get the same message when bootstrap3 is missing.
[2025-02-06 04:37:45] WARNING: Nikola: Cannot load theme "wxpy-theme", using 'bootblog4' instead.

@DietmarSchwertberger
Copy link
Contributor Author

Seems that the generation now is running through. The deployment itself is failing, obviously.

@swt2c
Copy link
Collaborator

swt2c commented Feb 7, 2025

I thought the deployment would actually work (it was supposed to deploy to a preview location), but after looking at it, it doesn't work when the pull request is from a fork, for security reasons. The preview is visible here:

#10

It looks good to me, other than the number of comments issue. I'll try to look into that, unless you have any ideas.

@DietmarSchwertberger
Copy link
Contributor Author

Thanks.
No, I don't have an idea why the number of comments is not shown any more.
I have to admit I did not dive too deep into Nikola.
I'm not a fan of such a declarative approach as it's always difficult to figure out which setting influences which output, even with a debugger.
I would have prefered a set of libraries that a build script would then call step by step. Similarly, how I prefer the imperative approach of wxWidgets over Qt's QML.

@DietmarSchwertberger
Copy link
Contributor Author

Regarding the problem with bootstrap4, see the screenshots here:
getnikola/nikola#3817 (comment)

@swt2c
Copy link
Collaborator

swt2c commented Feb 9, 2025

OK so the comments do seem to be working now, so I think we are good.

@swt2c swt2c merged commit 32cb4bc into wxWidgets:master Feb 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants