Conversation
|
The category descriptions seem to be case sensitive. They're now |
|
Hey @DietmarSchwertberger thanks for your work on this. I added a deploy preview Github Action that will attempt to build the site and deploy it to a preview location so we can easily review it. It seems the build is running into an error (see the failing check). Also to answer some of your earlier questions: if you need to add |
|
Thanks. I will try to add the action for the bootstrap3 installation. |
|
Seems that the generation now is running through. The deployment itself is failing, obviously. |
|
I thought the deployment would actually work (it was supposed to deploy to a preview location), but after looking at it, it doesn't work when the pull request is from a fork, for security reasons. The preview is visible here: It looks good to me, other than the number of comments issue. I'll try to look into that, unless you have any ideas. |
|
Thanks. |
|
Regarding the problem with bootstrap4, see the screenshots here: |
|
OK so the comments do seem to be working now, so I think we are good. |
A first attempt.
I have removed all requirements except Nikola itself.
I have tested with Python 3.12 and the current Nikola 8.3.1.
The result looks reasonable close to the current website version. I'm just missing the number of comments.
The
conf.pyis a merge from the old version with the currrent template from Nikola.The wxPython theme uses bootstrap3 as base. I tried bootstrap4, but then the navigation popups were not formatted correctly.
To install
nikola theme -i bootstrap3is required. Is it possible to do this automatically?I would have included a local copy into the repository, but
.gitignorehas some theme related entries:Maybe, Robin did use local, modified copies. Should I remove the ignore entries and include a
bootstrap3copy?The modifications include a local version of the listing.plugin to avoid the empty lineanchors
(at
plugins/compile/rest/listing.plugin, theutils.NikolaPygmentsHTMLargumentanchor_refis commented out).This should fix the accessibility problems with the code samples wxWidgets/Phoenix#2677
It can be removed once Pygments PR pygments/pygments#2848 is merged into a release.