Skip to content

Conversation

@aklinker1
Copy link
Member

@aklinker1 aklinker1 commented Oct 31, 2024

This way we're free to make breaking changes to the storage API without making breaking changes to WXT. This also gives non-WXT extensions access to the same API.

  • Create the package
  • Double check README
  • Double check docs
  • Remove any unnecessary dependencies from WXT

@netlify
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit ab36db9
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6736151eeca5370008953f9c
😎 Deploy Preview https://deploy-preview-1129--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title chore: Extract wxt/storage to its own package chore: Extract wxt/storage to its own package, @wxt-dev/storage Oct 31, 2024
@aklinker1 aklinker1 marked this pull request as ready for review October 31, 2024 14:40
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (62ea796) to head (ab36db9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/storage.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   81.97%   80.33%   -1.65%     
==========================================
  Files         127      127              
  Lines        6547     6031     -516     
  Branches     1152     1014     -138     
==========================================
- Hits         5367     4845     -522     
- Misses       1166     1171       +5     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 mentioned this pull request Oct 31, 2024
33 tasks
@aklinker1 aklinker1 changed the title chore: Extract wxt/storage to its own package, @wxt-dev/storage feat: Extract wxt/storage to its own package, @wxt-dev/storage Nov 14, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1129

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1129

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1129

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1129

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1129

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1129

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1129

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1129

wxt

pnpm add https://pkg.pr.new/wxt@1129

commit: ab36db9

@aklinker1 aklinker1 merged commit d74f6b0 into main Nov 14, 2024
17 checks passed
@aklinker1 aklinker1 deleted the extract-storage branch November 14, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants