-
-
Notifications
You must be signed in to change notification settings - Fork 445
fix: Throw when config file does not exist #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge once checks pass
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/unocss
wxt
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 82.34% 82.27% -0.07%
==========================================
Files 127 127
Lines 6767 6770 +3
Branches 1133 1152 +19
==========================================
- Hits 5572 5570 -2
- Misses 1181 1186 +5
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Currently, if provide a non-existent config file(like typo or something else), it would fallback to default config and may throw some misleading err. Maybe we should handle this case and abort it explicitly.
Before
After