Skip to content

Conversation

@kongmoumou
Copy link
Contributor

@kongmoumou kongmoumou commented Nov 11, 2024

Currently, if provide a non-existent config file(like typo or something else), it would fallback to default config and may throw some misleading err. Maybe we should handle this case and abort it explicitly.

Before

image

After

image

@netlify
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 23a01d3
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6733691472ba4e0009359742
😎 Deploy Preview https://deploy-preview-1156--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge once checks pass

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1156

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1156

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1156

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1156

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1156

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1156

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1156

wxt

pnpm add https://pkg.pr.new/wxt@1156

commit: 23a01d3

@kongmoumou kongmoumou requested a review from aklinker1 November 12, 2024 14:42
@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (5d991ed) to head (23a01d3).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   82.34%   82.27%   -0.07%     
==========================================
  Files         127      127              
  Lines        6767     6770       +3     
  Branches     1133     1152      +19     
==========================================
- Hits         5572     5570       -2     
- Misses       1181     1186       +5     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title fix: should throw when config file not exist fix: Throw when config file does not exist Nov 13, 2024
@aklinker1 aklinker1 merged commit aa14676 into wxt-dev:main Nov 13, 2024
@aklinker1
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants