fix: Add / to PublicPath and browser.runtime.getURL #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/unocss
wxt
commit: |
aklinker1
requested changes
Nov 14, 2024
Member
There was a problem hiding this comment.
Yeah, looks good. Run tests and update the test snapshots so PR checks pass:
cd packages/wxt
pnpm test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
+ Coverage 81.51% 81.95% +0.44%
==========================================
Files 127 127
Lines 6546 6546
Branches 1148 1152 +4
==========================================
+ Hits 5336 5365 +29
+ Misses 1196 1167 -29
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@aklinker1 Done. |
aklinker1
approved these changes
Nov 14, 2024
Member
There was a problem hiding this comment.
Thanks! This might not be released for a little while, will go out in the next batch of changes. Until then, you can install it via: #1171 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aklinker1
Fixes #984
This seems to be working as you mentioned we need to change
getPathsDeclarationEntryfunction only.Do let me know your thoughts.