Skip to content

Conversation

@aklinker1
Copy link
Member

@aklinker1 aklinker1 commented Nov 14, 2024

Before, all WXT extensions shared the same event name, meaning if you had multiple installed they would invalidate each other.

Now, the event includes the extension ID, so it only invalidates itself.

This closes #1155

@netlify
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 7d0141f
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/673624c4860ac800081ff0fc
😎 Deploy Preview https://deploy-preview-1175--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +38 to +40
private static SCRIPT_STARTED_MESSAGE_TYPE = getUniqueEventName(
'wxt:content-script-started',
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was already using this function for this event... but I was using it for wxt:locationchange, must have misremembered where it was used.

@aklinker1 aklinker1 self-assigned this Nov 14, 2024
@aklinker1 aklinker1 added the bug label Nov 14, 2024
@aklinker1 aklinker1 marked this pull request as ready for review November 14, 2024 16:28
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1175

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1175

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1175

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1175

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1175

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1175

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1175

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1175

wxt

pnpm add https://pkg.pr.new/wxt@1175

commit: 7d0141f

@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (f5b7f7e) to head (7d0141f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   80.33%   80.44%   +0.10%     
==========================================
  Files         127      127              
  Lines        6031     6033       +2     
  Branches     1014     1014              
==========================================
+ Hits         4845     4853       +8     
+ Misses       1171     1165       -6     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 52e5387 into main Nov 14, 2024
17 checks passed
@aklinker1 aklinker1 deleted the fix-content-script-context-scope branch November 14, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'stopOldScripts' event is sent multiple times.

2 participants