Skip to content

Conversation

@aklinker1
Copy link
Member

@aklinker1 aklinker1 commented Nov 14, 2024

This close #857, #863, #939.

There were lots of callbacks and dependencies between variables in the createServer function... I was able to clean it up apart of this PR! Very happy about that, wasn't sure how I would work around that...

I don't have E2E tests for dev mode, so we'll need to check over this carefully.

Todo

@netlify
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 239bd63
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6738af4c1d7a7200086bc297
😎 Deploy Preview https://deploy-preview-1176--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title fix: Re-initialize WXT modules when wxt.config.ts file changes during development fix: Re-initialize WXT modules correctly during development Nov 14, 2024
@aklinker1 aklinker1 mentioned this pull request Nov 14, 2024
33 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1176

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1176

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1176

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1176

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1176

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1176

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1176

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1176

wxt

pnpm add https://pkg.pr.new/wxt@1176

commit: 239bd63

@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 79.24528% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.34%. Comparing base (52e5387) to head (239bd63).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/core/create-server.ts 71.62% 21 Missing ⚠️
packages/wxt/src/core/wxt.ts 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   80.65%   80.34%   -0.31%     
==========================================
  Files         127      127              
  Lines        6033     6066      +33     
  Branches     1016     1019       +3     
==========================================
+ Hits         4866     4874       +8     
- Misses       1152     1177      +25     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review November 16, 2024 14:42
@aklinker1 aklinker1 merged commit db025cd into main Nov 16, 2024
@aklinker1 aklinker1 deleted the module-reload branch November 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants