fix: Make injectScript wait until script is actually loaded#1763
Merged
aklinker1 merged 7 commits intowxt-dev:mainfrom Dec 16, 2025
Merged
fix: Make injectScript wait until script is actually loaded#1763aklinker1 merged 7 commits intowxt-dev:mainfrom
injectScript wait until script is actually loaded#1763aklinker1 merged 7 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ion1
changed the title
Everything seems to work: the script is executed; onload, onerror handlers do the right thing; document.currentScript invoked by the script returns the detached script element.
ion1
force-pushed
the
inject-script-wait
branch
from
5af7647 to
567f913
Compare
It enables the modification of the script element just before it is added to the DOM. It can be used to e.g. modify `script.async`/`script.defer`, add event listeners to the element, or pass data to the script via `script.dataset` (which can be accessed by the script via `document.currentScript`).
The documentation states: > `injectScript` returns a promise, that when resolved, means the script > has been evaluated by the browser and you can start communicating with > it. However, currently `injectScript` returns as soon as the `script` element has been added to the DOM. Make `injectScript` behave according to the documentation.
ion1
force-pushed
the
inject-script-wait
branch
from
567f913 to
a52b234
Compare
This was referenced Aug 3, 2025
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
==========================================
- Coverage 76.70% 76.09% -0.61%
==========================================
Files 113 113
Lines 3026 3041 +15
Branches 686 686
==========================================
- Hits 2321 2314 -7
- Misses 624 643 +19
- Partials 81 84 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
changed the title
injectScript wait until script is actually loaded
Add a promise to handle script loading completion
aklinker1
approved these changes
Dec 16, 2025
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The patch series in which each PR builds on top of the previous one: #1761, #1762, #1763 (you are here), #1838, #1765.
In case some of the changes are rejected, I will rebase the subsequent PRs on top of main.
Overview
The documentation states:
However, currently
injectScriptreturns as soon as thescriptelement has been added to the DOM.This PR makes
injectScriptbehave according to the documentation.Manual Testing
Invoke
injectScriptand observe that it will wait until the script has loaded.Related Issue
N/A