-
-
Notifications
You must be signed in to change notification settings - Fork 441
fix: adding missing chromiumPort parameter in web-ext.ts to enable fixed port debugging #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fix enable to setup a fixed port to enable easy debugging with VSCode or other IDEs
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
==========================================
+ Coverage 81.01% 81.09% +0.07%
==========================================
Files 130 130
Lines 6649 6650 +1
Branches 1089 1088 -1
==========================================
+ Hits 5387 5393 +6
+ Misses 1251 1246 -5
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sylvaneau That's amazing, small fix and if it works that's gooooddd job :) I was wondering to take that task, but it seems done now <3 Last step is to solve CI issue, you need to edit PR title |
|
I do not undernstand the failing checks, it seems it has no relation with the part i've modified. |
Check failed because of PR title there's some kind of linter for it, now should be good, but it need to be approved by owner again. I don't see all CI workflows because i'm on mobile currently 🙂 |
Hello, no I have already updated the name of the PR, the error is related to a completely different item: |
|
@sylvaneau Yeah, PR title validation is valid right now, you need to fix issue with eslint in code, let's take deeper look on failed workflow |
|
I did had a deeper look in the failed workflow and it is not an eslint issue :-) it's a transpilation issue. The issue was present on main before my push request and previous merge requests have been accepted with it, so I suppose we just need to wait for the maintainer to accept this one :-) |
|
@sylvaneau Ok, in that case it need to be fix in other PR. |
|
Gave this a test run and it doesn't appear that you can set breakpoints on the background script no? I only got the content scripts to trip. |
|
By running |
|
So it seems the problem is related to Chrome and VSCode and is not currently really fixed. Someone has managed to do it but I cannot reproduce... microsoft/vscode-js-debug#1445 Also the alternative way described by this guy allows to debug background with Chrome tools, but not with vscode... |
|
personally couldn't get that to work yet, I'll try it on a the template extension but something interesting I discovered is that when you have the debugger connected when you open the popup it will always open devtools which is nice |
|
Don't use VSCode personally, but this is a good fix regardless. Merged with latest |
|
Thanks for helping make WXT better! |
This fix enable to setup a fixed port to enable easy debugging with VSCode or other IDEs
Overview
Everything was already there, I've just added the line to pass the parameters sets in wxtUserConfig to the web-ext runner.
Manual Testing
chromiumPortin wxt.config.ts.npm run devremote-debugging-portis the same as set in config fileYou can also setup a fully working environment with this repo https://github.com/sylvaneau/wxt-react-vscode-template and try to debug your project with VSCode.
Related Issue
This PR closes #52