-
-
Notifications
You must be signed in to change notification settings - Fork 396
fix: wxt prepare
fails with the error "__vite_ssr_exportName__ is not defined" when using Vite 7
#1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ot defined" when using Vite 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where wxt prepare
fails with the error "vite_ssr_exportName is not defined" when using Vite 7 by updating the vite-node dependency version.
- Updates vite-node dependency to support version ^3.2.4 instead of ^3.1.2
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can vite-node 2 be removed from scope?
Not for now, no. Since WXT supports vite 5-7, we need vite-node 2 for vite 5
Yes, we can. Seems like vite-node 3.2.5 supports vite ≥ 5!
https://www.npmjs.com/package/vite-node/v/3.2.4?activeTab=code
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 81.40% 81.31% -0.09%
==========================================
Files 131 131
Lines 6679 6679
Branches 1098 1098
==========================================
- Hits 5437 5431 -6
- Misses 1232 1238 +6
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I manually tested vite@5 and vite-node@3 and found no issues, so I removed vite-node@2 from the dependencies. |
It works for me. Thanks! |
Overview
See https://discord.com/channels/1212416027611365476/1411816139700437072
The minimum vite-node version required for vite 7 is 3.2.0. Lower versions may have compatibility issues.
Related: vitest-dev/vitest#7925 and vitejs/vite#19996
Can vite-node 2 be removed from scope?