type(storage): when having init option, the value type should not contain null
#1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
Fixes a TypeScript type issue where storage items with an init option incorrectly included null in their value type. The PR adds a more specific method overload to ensure proper typing when the init option is provided.
- Adds a specific method overload for
defineItemwhen theinitoption is present - Ensures the return type correctly excludes
nullwhen initialization is guaranteed
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aiktb
changed the title
init option, the value type should not contain nullinit option, the value type should not contain null
|
same #1909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Manual Testing
Related Issue
This PR closes #<issue_number>