Skip to content

refactor!: move to module-runner#1946

Merged
aklinker1 merged 2 commits intowxt-dev:majorfrom
lishaduck:module-runner
Dec 16, 2025
Merged

refactor!: move to module-runner#1946
aklinker1 merged 2 commits intowxt-dev:majorfrom
lishaduck:module-runner

Conversation

@lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Oct 22, 2025 •
edited by aklinker1
Loading

Warning

Breaking Change

Drop support for Vite <6

Overview

Drop vite-node in favor of Vite-native runnerImport, which is based on ModuleRunner.

Manual Testing

Good question... not entirely sure what fails the treeshake in the first place, but all the tests pass so I assume it loads the entrypoints at least. 🤷🏻‍♂️

Related Issue

Stacked on #1945.
Supersedes/closes #1884.

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit f137b01
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68f85a0207997100088da048
😎 Deploy Preview https://deploy-preview-1946--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lishaduck lishaduck changed the base branch from main to major October 26, 2025 01:38
@aklinker1
Copy link
Member

aklinker1 commented Oct 27, 2025

If tests pass, that should be good enough.

aklinker1
aklinker1 approved these changes Oct 27, 2025
View reviewed changes
packages/wxt/package.json
},
"peerDependencies": {
"vite": "^5.4.19 || ^6.3.4 || ^7.0.0"
"vite": "^6.3.4 || ^7.0.0"
Copy link
Member

@aklinker1 aklinker1 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, was gonna call this out.

@aklinker1 aklinker1 changed the title refactor: move to module-runner refactor!: move to module-runner Oct 27, 2025
@lishaduck
Copy link
Contributor Author

lishaduck commented Oct 29, 2025 •
edited
Loading

This PR is an absolute mess, but it works. Cleanup later if I have time, I need to hit the hay

I say that and then I whip out grbi. Life is better now, I can sleep in good conscience.
Apparently the issue was that #1945 updated the locked vite version but didn't sync it right, which I tried to fix in here but downgraded instead of upgrading. Fixed that 😅 And guess what? Wouldn't have been (as much of) an issue if Vitepress used a peer... lol

@lishaduck
fix: vite versions
5f574b4 
Life would be soooo much easier if Vitepress would just release Vite>5.
@lishaduck
refactor: move to module runner
42a8693 
Related: wxt-dev#1214.
Related: wxt-dev#1044.
@lishaduck lishaduck force-pushed the module-runner branch 2 times, most recently from a12076a to 42a8693 Compare October 29, 2025 05:34
@aklinker1
Copy link
Member

aklinker1 commented Dec 16, 2025

Wouldn't have been (as much of) an issue if Vitepress used a peer... lol

Haha yeah, vite should always be a peer is what I've discovered.

@aklinker1 aklinker1 merged commit 7cb2659 into wxt-dev:major Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Thanks for helping make WXT better!

@lishaduck lishaduck deleted the module-runner branch December 16, 2025 18:36
@aklinker1 aklinker1 mentioned this pull request Feb 7, 2026
Closed
aklinker1 pushed a commit that referenced this pull request Feb 7, 2026
@lishaduck @aklinker1
refactor!: move to module-runner (#1946)
5b8a7d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aklinker1 aklinker1 aklinker1 approved these changes

@Timeraa Timeraa Awaiting requested review from Timeraa Timeraa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lishaduck @aklinker1