-
-
Notifications
You must be signed in to change notification settings - Fork 459
fix: Add .jsonc support for locale files to match docs
#2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aklinker1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
==========================================
- Coverage 76.25% 76.09% -0.17%
==========================================
Files 113 113
Lines 3049 3049
Branches 686 686
==========================================
- Hits 2325 2320 -5
- Misses 642 645 +3
- Partials 82 84 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.jsonc support for locale files
.jsonc support for locale files.jsonc support for locale files to match docs
|
Thanks for helping make WXT better! |
Overview
Added jsonc to allowed locale extensions. It was mentioned in documentation that jsonc extensions is supported but in reality there is an error. Looks like just missed here
Manual Testing
Create a locale in
<srcDir>/locales/<default_locale>.jsoncand you will notice that it simply crashes duringpreparestep withERROR [i18n] Required localization file does not exist: <localesDir>/en.{json|json5|yml|yaml|toml}. After fix it works as intended