Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
==========================================
+ Coverage 76.31% 76.35% +0.03%
==========================================
Files 115 115
Lines 3074 3074
Branches 681 681
==========================================
+ Hits 2346 2347 +1
Misses 646 646
+ Partials 82 81 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
left a comment
There was a problem hiding this comment.
I only looked a the test file. Revert those changes so the tests expect type errors for invalid function calls, then I'll look at the rest of this PR.
There was a problem hiding this comment.
This file tests types by expecting type errors for invalid function calls. That means we need the // @ts-expect-error is present here. Revert it or find another way to test that type errors exist in these cases.
aklinker1
left a comment
There was a problem hiding this comment.
Woops, meant to request changes.
|
@aklinker1 Now it should be good |
18b6aee to
d7363bb
Compare
d7363bb to
d0e41a7
Compare
|
@aklinker1 Conflicts resolved 😄 |
This reverts commit 61bd550.
11dfd0e to
e254767
Compare
|
@aklinker1 Again, let's check it :) |
Overview
I've done my best, to type it, if anybody have better idea to do this, i'm open for edit suggestion.
Manual Testing
Let's see if CI pass