fix: escape virtual module import paths with apostrophes

packages/wxt/src/core/builders/vite/plugins/__tests__/resolveVirtualModules.test.ts

@@ -0,0 +1,45 @@
+import fs from 'fs-extra';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, describe, expect, it } from 'vitest';
+import { resolveVirtualModules } from '../resolveVirtualModules';
+import { fakeResolvedConfig } from '../../../../utils/testing/fake-objects';
+
+const tempDirs: string[] = [];
+
+afterEach(async () => {
+  await Promise.all(tempDirs.splice(0).map((dir) => fs.remove(dir)));
+});
+
+describe('resolveVirtualModules', () => {
+  it.each([
+    `import definition from 'virtual:user-background-entrypoint';`,
+    `import definition from "virtual:user-background-entrypoint";`,
+  ])(
+    'should escape input paths when template contains %s',
+    async (template) => {
+      const wxtModuleDir = await fs.mkdtemp(join(tmpdir(), 'wxt-test-'));
+      tempDirs.push(wxtModuleDir);
+
+      await fs.outputFile(
+        join(wxtModuleDir, 'dist/virtual/background-entrypoint.mjs'),
+        template,
+      );
+
+      const plugin = resolveVirtualModules(
+        fakeResolvedConfig({ wxtModuleDir }),
+      ).find(
+        (plugin) => plugin.name === 'wxt:resolve-virtual-background-entrypoint',
+      );
+
+      expect(plugin).toBeDefined();
+
+      const inputPath = `/tmp/foo'bar/background.ts`;
+      const code = await plugin!.load!(
+        '\0virtual:wxt-background-entrypoint?' + inputPath,
+      );
+
+      expect(code).toBe(`import definition from ${JSON.stringify(inputPath)};`);
+    },
+  );
+});

packages/wxt/src/core/builders/vite/plugins/resolveVirtualModules.ts

@@ -14,6 +14,7 @@ import { resolve } from 'path';
 export function resolveVirtualModules(config: ResolvedConfig): Plugin[] {
   return virtualModuleNames.map((name) => {
     const virtualId: `${VirtualModuleId}?` = `virtual:wxt-${name}?`;
+    const userVirtualId = `virtual:user-${name}`;
     const resolvedVirtualId = '\0' + virtualId;
     return {
       name: `wxt:resolve-virtual-${name}`,
@@ -34,7 +35,16 @@ export function resolveVirtualModules(config: ResolvedConfig): Plugin[] {
           resolve(config.wxtModuleDir, `dist/virtual/${name}.mjs`),
           'utf-8',
         );
-        return template.replace(`virtual:user-${name}`, inputPath);
+        const escapedPath = JSON.stringify(inputPath);
+        const code = template
+          .replace(`'${userVirtualId}'`, escapedPath)
+          .replace(`"${userVirtualId}"`, escapedPath);
+        if (code === template) {
+          throw Error(
+            `Failed to resolve virtual module "${name}": expected template import "${userVirtualId}"`,
+          );
+        }
+        return code;
       },
     };
   });