fix: allow user-defined sidebar_action to override generated fields#2189
Open
djyde wants to merge 1 commit intowxt-dev:mainfrom
Open
fix: allow user-defined sidebar_action to override generated fields#2189djyde wants to merge 1 commit intowxt-dev:mainfrom
djyde wants to merge 1 commit intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sidebar_actionmanifest field for Firefox was being completely overwritten by WXT, ignoring user-defined configuration fromwxt.config.tssidebar_actionfields now properly override auto-generated valuesChanges
packages/wxt/src/core/utils/manifest.tsto spread user-definedsidebar_actionconfiguration after generated fields, allowing user values to take precedencepackages/wxt/src/core/utils/__tests__/manifest.test.tsto verify user configuration is properly mergedTest Plan
custom_field) are preserveddefault_panelis still included