chore: remove useDefineForClassFields from svelte/tsconfig.json#2190
Open
g1eny0ung wants to merge 1 commit intowxt-dev:mainfrom
Open
chore: remove useDefineForClassFields from svelte/tsconfig.json#2190g1eny0ung wants to merge 1 commit intowxt-dev:mainfrom
g1eny0ung wants to merge 1 commit intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
- Coverage 76.31% 76.25% -0.07%
==========================================
Files 115 115
Lines 3074 3074
Branches 681 681
==========================================
- Hits 2346 2344 -2
- Misses 646 648 +2
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As https://www.typescriptlang.org/tsconfig/#useDefineForClassFields says,
useDefineForClassFieldswill default totruewhen target is ES2022 or higher, including ESNext.Since wxt uses
target: ESNextby default, we can omit this option.Manual Testing
Removed it and tested in my project.
Related Issue
None.