Skip to content

chore: remove useDefineForClassFields from svelte/tsconfig.json#2190

Open
g1eny0ung wants to merge 1 commit intowxt-dev:mainfrom
g1eny0ung:patch-1
Open

chore: remove useDefineForClassFields from svelte/tsconfig.json#2190
g1eny0ung wants to merge 1 commit intowxt-dev:mainfrom
g1eny0ung:patch-1

Conversation

@g1eny0ung
Copy link

Overview

As https://www.typescriptlang.org/tsconfig/#useDefineForClassFields says, useDefineForClassFields will default to true when target is ES2022 or higher, including ESNext.

Since wxt uses target: ESNext by default, we can omit this option.

Manual Testing

Removed it and tested in my project.

Related Issue

None.

@g1eny0ung g1eny0ung requested a review from aklinker1 as a code owner March 12, 2026 08:54
@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 4e8eb25
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69b27f6543e8e400086d6b19
😎 Deploy Preview https://deploy-preview-2190--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😄

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2190

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2190

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2190

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2190

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2190

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2190

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2190

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2190

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2190

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2190

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2190

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2190

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2190

wxt

npm i https://pkg.pr.new/wxt@2190

commit: 5966f95

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.25%. Comparing base (5fe4681) to head (4e8eb25).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
- Coverage   76.31%   76.25%   -0.07%     
==========================================
  Files         115      115              
  Lines        3074     3074              
  Branches      681      681              
==========================================
- Hits         2346     2344       -2     
- Misses        646      648       +2     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) March 12, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants