Open
Conversation
An option with `no-` prefix returns `false`. https://docs.ruby-lang.org/ja/latest/class/OptionParser.html > また、"no-" をオプションの先頭に付けた場合は値が反転します。
Collaborator
Author
|
Hmm we still need to be able to access remote repos when running So I assume that |
Member
|
Indeed, as @ikesyo wrote, this change does not fulfill the original purpose. However, it's terrible that --no-fetch is currently not fully working, and in the meantime, implementing this option will reduce execution time, albeit by a few tenths of a second. So I think there are two choices.
I would like to propose that we merge this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18
An option with
no-prefix returnsfalse.https://docs.ruby-lang.org/ja/latest/class/OptionParser.html
Currently
@no_fetchis eithernilorfalse, sogit :remote, 'update', 'origin' unless @no_fetchwill be executed always.