Better Filesystem Capability Checks (e.g. volname & st_birthtime)#5
Open
CoordSpace wants to merge 3 commits intox1ppy:masterfrom
Open
Better Filesystem Capability Checks (e.g. volname & st_birthtime)#5CoordSpace wants to merge 3 commits intox1ppy:masterfrom
CoordSpace wants to merge 3 commits intox1ppy:masterfrom
Conversation
powerarmorpatch
pushed a commit
to powerarmorpatch/freezetag
that referenced
this pull request
May 25, 2023
PR#5 by CoordSpace to original repository by x1ppy x1ppy#5 Original message: When running freezetag mount on non-Mac filesystems, the current set of file attributes and fuse mount settings cause Runtime Errors with fuse such as fuse: unknown option "volname=Music-freezetag" and trigger the persistent process to instantly crash out. This patch swaps out checks for OS(es) that don't support these features (e.g. if platform.system() != 'Windows') for checks that see if freezetag is running on the one OS variant that does support them: Darwin. This will allow linux (and maybe windows) users to use freezetag mount with filesystems that do not support that same filesystem feature set as MacOS. So far this patch has been tested on the latest versions of Ubuntu Server and Debian and it clears the hurdles that prevented the new filesystem from being created, allowing well-behaved FLAC and MP3 files to work as expected.
undaunt
referenced
this pull request
in undaunt/freezetag
May 7, 2024
Better Filesystem Capability Checks (e.g. volname & st_birthtime) #5
|
@CoordSpace Added this to my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
freezetag mounton non-Mac filesystems, the current set of file attributes and fuse mount settings cause Runtime Errors with fuse such asfuse: unknown option "volname=Music-freezetag"and trigger the persistent process to instantly crash out.This patch swaps out checks for OS(es) that don't support these features (e.g.
if platform.system() != 'Windows') for checks that see if freezetag is running on the one OS variant that does support them: Darwin. This will allow linux (and maybe windows) users to usefreezetag mountwith filesystems that do not support that same filesystem feature set as MacOS.So far this patch has been tested on the latest versions of Ubuntu Server and Debian and it clears the hurdles that prevented the new filesystem from being created, allowing well-behaved FLAC and MP3 files to work as expected.