UI Test reliability updates (#12012)

* UI test reliability updates
- retry text request on API 19
- change monkeys to load all from internal URLS

* - more clicking

* - adjust tests a bit more

* - coalesce

* - smaller monkies

Author: PureWeen

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue9682.xaml

@@ -36,7 +36,7 @@
                                     <ColumnDefinition Width="Auto" />
                                     <ColumnDefinition Width="*" />
                                 </Grid.ColumnDefinitions>
-                                <Image Aspect="AspectFill" AutomationId="MonkeyImages">
+                                <Image Aspect="AspectFit" AutomationId="MonkeyImages">
                                     <Image.Source>
                                         <UriImageSource Uri="{Binding Image}" CachingEnabled="False"></UriImageSource>
                                     </Image.Source>

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue9682.xaml.cs

@@ -50,15 +50,17 @@ public void MonkiesShouldLoad()
 			{
 				var images = RunningApp.WaitForElement("MonkeyImages");
 
-				if (images[0].Rect.Height < 50 || images[0].Rect.Width < 50)
+				if (images[0].Rect.Height < 20 || images[0].Rect.Width < 20)
 					return null;
 
 				return images;
 			});
 
+			monkeyImages = monkeyImages ?? RunningApp.WaitForElement("MonkeyImages");
+
 			Assert.IsNotNull(monkeyImages);
-			Assert.GreaterOrEqual(monkeyImages[0].Rect.Height, 50);
-			Assert.GreaterOrEqual(monkeyImages[0].Rect.Width, 50);
+			Assert.GreaterOrEqual(monkeyImages[0].Rect.Height, 20);
+			Assert.GreaterOrEqual(monkeyImages[0].Rect.Width, 20);
 		}
 #endif
 	}
@@ -133,8 +135,46 @@ async Task GetMonkeysAsync()
 			try
 			{
 				IsBusy = true;
-				var json = await Client.GetStringAsync("https://montemagno.com/monkeys.json");
-				Monkey[] monkeys = Monkey.FromJson(json);
+				await Task.Delay(500);
+				Monkey[] monkeys = new[]
+				{
+					new Monkey()
+					{
+						Details = "Climbs high buildings and enjoys swatting at planes",
+						Latitude = 42,
+						Longitude = 42,
+						Location = "Empire State Building",
+						Name = "King Kong",
+						Image = "https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/Fruits.jpg?raw=true"
+					},
+					new Monkey()
+					{
+						Details = "Monkeys aren't donkeys, Quit messing with my head!",
+						Latitude = 42,
+						Longitude = 42,
+						Location = "The 90s",
+						Name = "Donkey Kong",
+						Image = "https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/FlowerBuds.jpg?raw=true"
+					},
+					new Monkey()
+					{
+						Details = "Grape Ape, Grape Ape! Grape Ape, Grape Ape! Grape Ape, Grape Ape! Grape Ape, Grape Ape!",
+						Latitude = 42,
+						Longitude = 42,
+						Location = "Sunday Mornings",
+						Name = "Grape Ape",
+						Image = "https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/games.png?raw=true"
+					},
+					new Monkey()
+					{
+						Details = "Pretty but easily persuaded into doing others biddings",
+						Latitude = 42,
+						Longitude = 42,
+						Location = "The Sky",
+						Name = "Flying Monkey",
+						Image = "https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/gear.png?raw=true"
+					},
+				};
 
 				Monkeys.Clear();
 				foreach (var monkey in monkeys)

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellBackButtonBehavior.cs

@@ -48,7 +48,12 @@ public class BackButtonPage : ContentPage
 		{
 			BackButtonBehavior behavior = new BackButtonBehavior();
 			Entry _commandParameter;
-			Label _commandResult = new Label() { AutomationId = CommandResultId };
+			Label _commandResult = new Label()
+			{
+				AutomationId = CommandResultId,
+				BackgroundColor = Color.LightBlue,
+				Text = "Label"
+			};
 
 			public BackButtonPage()
 			{
@@ -224,13 +229,28 @@ public void CommandTest()
 			RunningApp.EnterText(EntryCommandParameter, "parameter");
 			ShowFlyout();
 
-			var commandResult = RunningApp.WaitForElement(CommandResultId)[0].ReadText();
+			// API 19 workaround
+			var commandResult = RunningApp.QueryUntilPresent(() =>
+			{
+				ShowFlyout();
+				if (RunningApp.WaitForElement(CommandResultId)[0].ReadText() == "parameter")
+					return RunningApp.WaitForElement(CommandResultId);
+
+				return null;
+			})?.FirstOrDefault()?.ReadText();
 
 			Assert.AreEqual("parameter", commandResult);
 			RunningApp.EnterText(EntryCommandParameter, "canexecutetest");
 			RunningApp.Tap(ToggleCommandCanExecuteId);
 
-			commandResult = RunningApp.WaitForElement(CommandResultId)[0].ReadText();
+			commandResult = RunningApp.QueryUntilPresent(() =>
+			{
+				if (RunningApp.WaitForElement(CommandResultId)[0].ReadText() == "parameter")
+					return RunningApp.WaitForElement(CommandResultId);
+
+				return null;
+			})?.FirstOrDefault()?.ReadText();
+
 			Assert.AreEqual("parameter", commandResult);
 		}
 
@@ -241,13 +261,22 @@ public void CommandWorksWhenItsTheOnlyThingSet()
 			RunningApp.Tap(ToggleCommandId);
 			RunningApp.EnterText(EntryCommandParameter, "parameter");
 
+			// API 19 workaround
+			var commandResult = RunningApp.QueryUntilPresent(() =>
+			{
+
 #if __ANDROID__
-			base.TapBackArrow();
+				TapBackArrow();
 #else
-			RunningApp.Tap("Page 0");
+				RunningApp.Tap("Page 0");
 #endif
 
-			var commandResult = RunningApp.WaitForElement(CommandResultId)[0].ReadText();
+				if (RunningApp.WaitForElement(CommandResultId)[0].ReadText() == "parameter")
+					return RunningApp.WaitForElement(CommandResultId);
+
+				return null;
+			})?.FirstOrDefault()?.ReadText();
+
 			Assert.AreEqual(commandResult, "parameter");
 		}