Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit 8a13756

Browse files
authored
Disable animation scrolling to initial position in CarouselView (#11173) fixes #11081
1 parent 0c95d09 commit 8a13756

File tree

3 files changed

+78
-0
lines changed

3 files changed

+78
-0
lines changed
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<controls:TestContentPage
3+
xmlns="http://xamarin.com/schemas/2014/forms"
4+
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
5+
xmlns:controls="clr-namespace:Xamarin.Forms.Controls"
6+
xmlns:issues="clr-namespace:Xamarin.Forms.Controls.Issues"
7+
x:Class="Xamarin.Forms.Controls.Issues.Issue11081"
8+
Title="Issue 11081">
9+
<Grid>
10+
<Grid.RowDefinitions>
11+
<RowDefinition Height="Auto" />
12+
<RowDefinition Height="*" />
13+
</Grid.RowDefinitions>
14+
<Label
15+
Padding="12"
16+
BackgroundColor="Black"
17+
TextColor="White"
18+
Text="If the selected Item is the Item 2, directly without animations, the test has passed."/>
19+
<!-- AnimateInitialPosition is False by default-->
20+
<CarouselView
21+
Grid.Row="1"
22+
Position="1">
23+
<CarouselView.ItemTemplate>
24+
<DataTemplate>
25+
<Label
26+
Text="{Binding}"
27+
FontSize="Large"
28+
HorizontalOptions="CenterAndExpand"/>
29+
</DataTemplate>
30+
</CarouselView.ItemTemplate>
31+
<CarouselView.ItemsSource>
32+
<x:Array Type="{x:Type x:String}">
33+
<x:String>Item 1</x:String>
34+
<x:String>Item 2</x:String>
35+
<x:String>Item 3</x:String>
36+
<x:String>Item 4</x:String>
37+
<x:String>Item 5</x:String>
38+
</x:Array>
39+
</CarouselView.ItemsSource>
40+
</CarouselView>
41+
</Grid>
42+
</controls:TestContentPage>
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
using Xamarin.Forms.CustomAttributes;
2+
using Xamarin.Forms.Internals;
3+
4+
#if UITEST
5+
using Xamarin.UITest;
6+
using NUnit.Framework;
7+
using Xamarin.Forms.Core.UITests;
8+
#endif
9+
10+
namespace Xamarin.Forms.Controls.Issues
11+
{
12+
[Preserve(AllMembers = true)]
13+
[Issue(IssueTracker.Github, 11081, "[Bug] CarouselView should not animate an initial Position on Android",
14+
PlatformAffected.Android)]
15+
#if UITEST
16+
[Category(UITestCategories.CarouselView)]
17+
#endif
18+
public sealed partial class Issue11081 : TestContentPage
19+
{
20+
public Issue11081()
21+
{
22+
#if APP
23+
this.InitializeComponent();
24+
#endif
25+
}
26+
27+
protected override void Init()
28+
{
29+
30+
}
31+
}
32+
}

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1499,6 +1499,7 @@
14991499
<Compile Include="$(MSBuildThisFileDirectory)Issue11723.cs" />
15001500
<Compile Include="$(MSBuildThisFileDirectory)Issue11496.xaml.cs" />
15011501
<Compile Include="$(MSBuildThisFileDirectory)Issue11209.xaml.cs" />
1502+
<Compile Include="$(MSBuildThisFileDirectory)Issue11081.xaml.cs" />
15021503
</ItemGroup>
15031504
<ItemGroup>
15041505
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Bugzilla22229.xaml">
@@ -1802,6 +1803,9 @@
18021803
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue11209.xaml">
18031804
<Generator>MSBuild:UpdateDesignTimeXaml</Generator>
18041805
</EmbeddedResource>
1806+
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue11081.xaml">
1807+
<Generator>MSBuild:UpdateDesignTimeXaml</Generator>
1808+
</EmbeddedResource>
18051809
</ItemGroup>
18061810
<ItemGroup>
18071811
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Bugzilla27417Xaml.xaml">

0 commit comments

Comments
 (0)