This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Awaiting the inner task instead of outer task #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task.Factory.StartNew returns a nested task (Task). Awaiting a nested task is dangerous:
If DeAuthenticate() call returns false, an exception in line 63 will be thrown to the inner task. The exceptions in a task can only propagate to the caller if the task is awaited or waited. In line 58, only the outer task is awaited so the exceptions in the inner task will be swallowed and have no effect at all: the user will never see the “DeAuthenticate” error and the developer cannot handle this exception.
That's why, we should always unwrap the nested task (with Unwrap() or using Task.Run) and await the inner task.