Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Binding and Xaml layout fixes found with XamRight - http://criticalhittech.com/xamright/ #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Binding and Xaml layout fixes found with XamRight - http://criticalhittech.com/xamright/ #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6590c73
Binding and Xaml layout fixes found with XamRight
Apr 20, 2018
45baf05
More layout fixes
Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/MobileApp/XamarinCRM/Pages/Customers/CustomerOrdersPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ x:Class="XamarinCRM.Pages.Customers.CustomerOrdersPage"
xmlns:views="clr-namespace:XamarinCRM.Views"
xmlns:base="clr-namespace:XamarinCRM.Pages.Customers"
xmlns:customerViews="clr-namespace:XamarinCRM.Views.Customers"
xmlns:layouts="clr-namespace:XamarinCRM.Layouts"
xmlns:statics="clr-namespace:XamarinCRM.Statics"
Title="{Binding DisplayContact}">
Title="{Binding Account.DisplayContact}">

<base:CustomerOrdersPageXaml.Content>

Expand Down
2 changes: 1 addition & 1 deletion src/MobileApp/XamarinCRM/Pages/Customers/CustomerSalesPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="XamarinCRM.Pages.Customers.CustomerSalesPage"
xmlns:base="clr-namespace:XamarinCRM.Pages.Customers"
xmlns:customerViews="clr-namespace:XamarinCRM.Views.Customers"
Title="{Binding DisplayContact}">
Title="{Binding Account.DisplayContact}">
<ScrollView>
<StackLayout Spacing="0">
<customerViews:CustomerWeeklySalesChartView />
Expand Down
2 changes: 0 additions & 2 deletions src/MobileApp/XamarinCRM/Pages/MenuPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ xmlns:controls="clr-namespace:ImageCircle.Forms.Plugin.Abstractions;assembly=Ima
<ContentPage.Content>
<ListView
SeparatorColor="Transparent"
Grid.ColumnSpan="3"
Grid.Row="4"
HasUnevenRows="true"
x:Name="ListViewMenu">
<ListView.Header>
Expand Down
1 change: 0 additions & 1 deletion src/MobileApp/XamarinCRM/Pages/Products/ProductDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ xmlns:i18n="clr-namespace:XamarinCRM.Localization"
HorizontalTextAlignment="End"
VerticalTextAlignment="Center" />
<Image
HorizontalOptions="End"
VerticalOptions="Center">
<Image.Source>
<OnPlatform x:TypeArguments="ImageSource">
Expand Down
3 changes: 1 addition & 2 deletions src/MobileApp/XamarinCRM/Views/Customers/CustomerOrderListView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ xmlns:converters="clr-namespace:XamarinCRM.Converters"
IsVisible="{Binding IsBusy, Converter={StaticResource inverseBooleanConverter}}"
IsEnabled="{Binding IsBusy, Converter={StaticResource inverseBooleanConverter}}"
ItemsSource="{Binding OrderGroups}"
IsGroupingEnabled="true"
GroupDisplayBinding="{Binding Key}">
IsGroupingEnabled="true">

<views:NonPersistentSelectedItemListView.Resources>
<ResourceDictionary>
Expand Down