Fix tests after merge conflicts #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commits 2ac4e67 & baa7044 whilst independently passing the unit tests fail when combined as baa7044 introduced a call `vhdutil.getBlockSize` in the snapshot path which was not mocked by the tests added in 2ac4e67. Add this mocking to fix the test. Signed-off-by: Mark Syms <[email protected]>
TimSmithCtx
approved these changes
Jan 22, 2026
rosslagerwall
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits 2ac4e67 & baa7044 whilst independently passing the unit tests fail when combined as baa7044 introduced a call
vhdutil.getBlockSizein the snapshot path which was not mocked by the tests added in 2ac4e67. Add this mocking to fix the test.