CP-310956: Remove legacy winbind configuration

[liulinC]

9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility.

Now samba binary is updated in all releases, this commit just drop the legacy configurations

[liulinC]

232236 (Dev Run) Authentication sanity test looks good.

[psafont]

Note: xcp-ng still hasn't updated to samba 4.20, this means that samba needs to be updated before this change is adapted in xcp-ng

[lindig]

Do we want to change it to:

# autogenerated by xapi
# do not change because changes will be overwritten"

[liulinC]

does't autogenerated by xapi already indicate changes will be overwritten? and we do expect customer to change it and restart winbind temporary for debug purpose.

[liulinC]

Note: xcp-ng still hasn't updated to samba 4.20, this means that samba needs to be updated before this change is adapted in xcp-ng

do we have an estimation about when it be done?
Can I merge now as the release may still takes time.

[psafont]

do we have an estimation about when it be done?

I don't think we need to wait to merge this, just to be aware of it, are you planning to add a dependency in the .spec file?

[stormi]

I'm not fond of a XAPI update enforcing a samba upgrade on a maintenance release of XCP-ng. I need to better understand why this change absolutely needs to be merged prior to branching off the maintenance branch of XS 8.4+XCP-ng 8.3.

[robhoes]

@stormi , I agree in principle, but this particular update was needed to address a serious issue for Window VMs. See the linked commit 9a468bf and https://bugzilla.samba.org/show_bug.cgi?id=15876.

[liulinC]

I'm not fond of a XAPI update enforcing a samba upgrade on a maintenance release of XCP-ng. I need to better understand why this change absolutely needs to be merged prior to branching off the maintenance branch of XS 8.4+XCP-ng 8.3.

1. samba was updated to 4.2x to address the issues mentioned by Rob
2. New samba updated its interface, thus the caller(xapi) needs to change to new interface as well.
   However, to support upgrade smoothly, xapi detect the samba version and use the proper interface, to support both old and new samba.
3. While step 2 is good as compatible, it makes code unnecessary complex. This PR is target to remove the support for old samba interface, to keep code simple and clean.
   This means, AD may not work well after this PR with old samba.

[lindig]

This PR is not large or complex. So we could hold it back or only merge it into the next major release and keeping the old code around on this release. But we do would like to not carry along old code.

[liulinC]

This PR is not large or complex. So we could hold it back or only merge it into the next major release and keeping the old code around on this release. But we do would like to not carry along old code.

In this case, I will hold this PR until xapi branch out.

[liulinC]

@psafont Can you help to tick the PR to indicate vates are happy with this merge?
Note: xapi has been branch out, so this merge will goes to next release only.

[psafont]

I have been told that samba 4.21.3 is being used in the xcp-ng 9 prototype, so the removal of support for older versions should be fine