xenops: Fix migrate parameter ordering #6823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localhost_migration was introduced as the last parameter for migrate in xenops_interface.ml, but was second to last in xenops_server.ml. This meant that non-localhost migrations with verify_dest=true were classed as localhost and did not balloon down before migration. Fixes: 0911604 ("xenopsd: Don't balloon down memory on same-host migration") Signed-off-by: Andrii Sultanov <[email protected]>
Collaborator
|
Not related to this change specifically, but ballooning a VM down for migrate is a terrible thing to be doing generally. It's far more expensive than just sending a page which isn't in active use, and it prevents using host superpages on the destination. |
psafont
approved these changes
Jan 8, 2026
Member
psafont
left a comment
psafont
left a comment
There was a problem hiding this comment.
Can these arguments become named?
Contributor
Author
We could create separate types for these arguments in a newtype fashion (so that they're not both bool, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localhost_migration was introduced as the last parameter for migrate in xenops_interface.ml, but was second to last in xenops_server.ml.
This meant that non-localhost migrations with verify_dest=true were classed as localhost and did not balloon down before migration.
Fixes: 0911604 ("xenopsd: Don't balloon down memory on same-host migration")