Check that suspend SR has enough space to save VM state #6847
+51
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a helper to compute the free space on a SR. It is used to check that the suspend SR has enough space when creating a snapshot with memory. If there is not enough space, SR_SUSPEND_SPACE_INSUFFICIENT is raised. Signed-off-by: Guillaume <[email protected]>
last-genius
approved these changes
Jan 20, 2026
lindig
approved these changes
Jan 20, 2026
robhoes
reviewed
Jan 20, 2026
| error Api_errors.sr_suspend_space_insufficient ["sr"] | ||
| ~doc: | ||
| "The suspend SR does not have sufficient free space to store the VM \ | ||
| suspend image required to complete a snapshot with memory." |
Member
There was a problem hiding this comment.
This should be a little more general, because the error is user not just for checkpoint, but also suspend. I would just remove the last part of the sentence ("required to complete a snapshot with memory").
Contributor
There was a problem hiding this comment.
This is a backport of a PR that was already merged into master. Should probably have another PR into master with this fix then?
Member
There was a problem hiding this comment.
Should probably have another PR into master with this fix then?
I think so, yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a helper to compute the free space on a SR. It is used to check that the suspend SR has enough space when creating a snapshot with memory. If there is not enough space, SR_SUSPEND_SPACE_INSUFFICIENT is raised.
This is a backport of #6838