CA-423369: fix suspend-SR space check (backport)#6883
Merged
edwintorok merged 1 commit intoxapi-project:26.1-lcmfrom Feb 4, 2026
Merged
CA-423369: fix suspend-SR space check (backport)#6883edwintorok merged 1 commit intoxapi-project:26.1-lcmfrom
edwintorok merged 1 commit intoxapi-project:26.1-lcmfrom
Conversation
Unfortunately, the SR size and utilisation fields are only set after an SR scan, and the new space check has been incorrectly rejecting suspends in some cases. Fix this by just catching the error from `VDI.create` and raising the new error to make it clear that it is the suspend SR that is out of space. Fixes 9402e88. Signed-off-by: Rob Hoes <rob.hoes@citrix.com> (cherry picked from commit 45e2ea9)
psafont
approved these changes
Feb 3, 2026
edwintorok
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the SR size and utilisation fields are only set after an SR scan, and the new space check has been incorrectly rejecting suspends in some cases.
Fix this by just catching the error from
VDI.createand raising the new error to make it clear that it is the suspend SR that is out of space.Fixes 9402e88.
(cherry picked from commit 45e2ea9)