CA-423760: Retain host.last_update_hash on an ejected host#6951
Open
minglumlu wants to merge 2 commits intoxapi-project:masterfrom
Open
CA-423760: Retain host.last_update_hash on an ejected host#6951minglumlu wants to merge 2 commits intoxapi-project:masterfrom
minglumlu wants to merge 2 commits intoxapi-project:masterfrom
Conversation
Generally an ejected host can be considered as a fresh-installed one. But in practice, the update level (the hash) is useful to determine the update state of an ejected host. One of the cases is a host was ejected from a pool. In this case, the retained applied update hash is useful to determine if the host can join the pool again easily. Signed-off-by: Ming Lu <ming.lu@cloud.com>
When pool.repositories becomes empty, the host.latest_synced_updates_applied is meaningless and it can't be refreshed by calling pool.sync_updates. Signed-off-by: Ming Lu <ming.lu@cloud.com>
psafont
reviewed
Mar 17, 2026
| let k = "last_update_hash" in | ||
| let x = Localdb.get k |> Option.value ~default:"" in | ||
| (try Localdb.del k with _ -> ()) ; | ||
| debug "Restore last_update_hash to %s ..." x ; |
Member
There was a problem hiding this comment.
This is going to be confusing with the empty string, better show it's meant to empty:
Suggested change
| debug "Restore last_update_hash to %s ..." x ; | |
| debug {|Restore last_update_hash to "%s" ...|} x ; |
Contributor
There was a problem hiding this comment.
You can use %S and it will be enclosed in quotes automatically.
lindig
approved these changes
Mar 17, 2026
| let k = "last_update_hash" in | ||
| let x = Localdb.get k |> Option.value ~default:"" in | ||
| (try Localdb.del k with _ -> ()) ; | ||
| debug "Restore last_update_hash to %s ..." x ; |
Contributor
There was a problem hiding this comment.
You can use %S and it will be enclosed in quotes automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally an ejected host can be considered as a fresh-installed one.
But in practice, the update level (the hash) is useful to determine the
update state of an ejected host.
One of the cases is a host was ejected from a pool. In this case, the
retained applied update hash is useful to determine if the host can join
the pool again easily.