packages: replace ocaml 5.3 with ocaml 5.4 #749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
force-pushed
the
dev/pau/ocaml54
branch
2 times, most recently
from
66d489f to
86022e6
Compare
Member
Author
|
bisect_ppx is blocking the merge at the moment. We're not realy using it, so we could drop it. In the meantime, the place where progress is happening is in aantron/bisect_ppx#448 |
psafont
force-pushed
the
dev/pau/ocaml54
branch
2 times, most recently
from
74d6357 to
235ac0f
Compare
This helps detect incompatible packages with 5.4 now that it has been released Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
It's not used and it's incompatible with OCaml 5.4 Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
This new version is compatible with ocaml 5.4 Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
This keeps the code compatible with previous versions of ocaml as well Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
While this version of ocamlformat is compatible with 4.14, we don't want to adopt it just yet, so I've added an artificial lower bound to its ocaml dependency Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
Updates ppxlib so it supports the new compiler AST. Unfortunately JST does not support old compilers and new versions of their libraries need to be brought in while keeping the existing ones. The same thing happens with rpclibs. Similarly with the new lsp server: the new merlin and lsp libraries require the new ocaml compiler. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
psafont
force-pushed
the
dev/pau/ocaml54
branch
from
235ac0f to
f237fd3
Compare
Member
Author
|
Because of the issues in ocamlformat, I think we probably should merge them first, and leave the upgrade for ocaml later, unless you want to do the packaging of ocaml 5.4 in the rpm at the same time this update goes through @robhoes |
Member
|
Yes no need to rush OCaml 5.4. |
Member
Author
|
I'll split the ocaml 5.4 upgrade from the preparation and ocamlformat update, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These needs a few more packages with multiple versions, it might need some rounds of CI.
Before merging, ocaml.spec should be prepared with a 5.4.0 version as well
Depends on #748 fixing the CI