Fixes decoding parametric coord #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 85.78% 86.30% +0.51%
==========================================
Files 13 15 +2
Lines 2364 2957 +593
Branches 183 256 +73
==========================================
+ Hits 2028 2552 +524
- Misses 303 360 +57
- Partials 33 45 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcherian
reviewed
Mar 14, 2025
cf_xarray/tests/test_accessor.py
Outdated
| assert romsds.z_rho.shape == (2, 30) | ||
| assert romsds.z_rho.attrs["standard_name"] == "height_above_geopotential_datum" | ||
|
|
||
| romsds.drop_vars("z_rho") |
There was a problem hiding this comment.
Suggested change
| romsds.drop_vars("z_rho") | |
| romsds = romsds.drop_vars("z_rho") |
dcherian
reviewed
Mar 14, 2025
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes decoding parametric coordinate when calling the accessor method.