Skip to content

Conversation

martinfleis
Copy link
Member

Fixes xarray-contrib/xvec#126

Neither the tests for the encoding in here and in xvec were able to catch this as we simply check the roundtrip, which does nothing in either direction...

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (a9cebee) to head (dbba5b4).
⚠️ Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   85.78%   93.67%   +7.89%     
==========================================
  Files          13       14       +1     
  Lines        2364     2230     -134     
  Branches      183        0     -183     
==========================================
+ Hits         2028     2089      +61     
+ Misses        303      141     -162     
+ Partials       33        0      -33     
Flag Coverage Δ
mypy ?
unittests 93.67% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis
Copy link
Member Author

A tiny request - if we manage to merge and release this before Sunday's LPS Xvec workshop, I'd appreciate it. I can't even downgrade xarray as it breaks something else 😅

@dcherian
Copy link
Contributor

Thanks!

@dcherian dcherian merged commit 82fbfe5 into xarray-contrib:main Jun 20, 2025
11 of 13 checks passed
@martinfleis martinfleis deleted the geom-detection branch June 20, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoded cube to zarr fails with TypeError: Cannot interpret '<geopandas.array.GeometryDtype object...

2 participants